Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0002322 [Quercus] minor always 01-13-08 12:58 01-28-08 13:06
Reporter ferg View Status public  
Assigned To mo
Priority normal Resolution fixed  
Status closed   Product Version
Summary 0002322: mediawiki: /wiki/includes/Skin.php:177: Fatal Error: Method call 'addMetadataLinks' is not allowed for a null value.
Description By browsing /wiki/index.php/Special:Preferences after changing language
Additional Information
Attached Files

- Relationships

- Notes
(0002658)
mo
01-17-08 21:46

After tracking down the cause of an install time error
with mediawiki 1.11.0, it seems likely like that bug and
this one have the same cause.

php/096l.qa

The problem is that the $this ref is getting set to null
when a subclass invokes an instance method in the super class.
This code does not fail with 3.1.4, so it must be related to
a change that has happened since then.
 
(0002659)
mo
01-18-08 13:20

Stepping through the interpreted code indicates that the problem
in located in StaticMethodExpr.eval():

The commented out code appears to set the $this value, but the
value is now set to NULL.

The comment also refs php/0954. This test also fails with the
current trunk.

This change was introduced in rev 3621.

It is unclear why StaticMethodExpr is being invoked here when
the function in question is not a static member function.
 
(0002688)
gjvc
01-28-08 02:54

This is fixed/does not happen in resin-3.1.s080126
 
(0002689)
mo
01-28-08 13:05

Added the following test cases for this problem:

        * php/096l.qa:
        * php/096m.qa:
        * php/096n.qa:
        * php/096o.qa:
        * php/096p.qa:
        * php/096q.qa:
        * php/096r.qa:
        * php/096s.qa:
        * php/396l.qa:
        * php/396m.qa:
        * php/396n.qa:
        * php/396o.qa:
        * php/396p.qa:
        * php/396q.qa:
        * php/396r.qa:
        * php/396s.qa:

I confirmed that this is fixed in the current trunk and gjvc reports
that it is fixed in the most recent snapshot.
 
(0002690)
mo
01-28-08 13:06

Fixed bug reverting static $this patch.
 

- Issue History
Date Modified Username Field Change
01-13-08 12:58 ferg New Issue
01-17-08 21:46 mo Note Added: 0002658
01-17-08 21:46 mo Status new => assigned
01-17-08 21:46 mo Assigned To  => mo
01-18-08 13:20 mo Note Added: 0002659
01-28-08 02:54 gjvc Note Added: 0002688
01-28-08 13:05 mo Note Added: 0002689
01-28-08 13:06 mo Status assigned => closed
01-28-08 13:06 mo Note Added: 0002690
01-28-08 13:06 mo Resolution open => fixed
01-28-08 13:06 mo Fixed in Version  => 3.1.5


Mantis 1.0.0rc3[^]
Copyright © 2000 - 2005 Mantis Group
38 total queries executed.
31 unique queries executed.
Powered by Mantis Bugtracker