Mantis - Quercus
Viewing Issue Advanced Details
2322 minor always 01-13-08 12:58 01-28-08 13:06
ferg  
mo  
normal  
closed  
fixed  
none    
none 3.1.5  
0002322: mediawiki: /wiki/includes/Skin.php:177: Fatal Error: Method call 'addMetadataLinks' is not allowed for a null value.
By browsing /wiki/index.php/Special:Preferences after changing language

Notes
(0002658)
mo   
01-17-08 21:46   
After tracking down the cause of an install time error
with mediawiki 1.11.0, it seems likely like that bug and
this one have the same cause.

php/096l.qa

The problem is that the $this ref is getting set to null
when a subclass invokes an instance method in the super class.
This code does not fail with 3.1.4, so it must be related to
a change that has happened since then.
(0002659)
mo   
01-18-08 13:20   
Stepping through the interpreted code indicates that the problem
in located in StaticMethodExpr.eval():

The commented out code appears to set the $this value, but the
value is now set to NULL.

The comment also refs php/0954. This test also fails with the
current trunk.

This change was introduced in rev 3621.

It is unclear why StaticMethodExpr is being invoked here when
the function in question is not a static member function.
(0002688)
gjvc   
01-28-08 02:54   
This is fixed/does not happen in resin-3.1.s080126
(0002689)
mo   
01-28-08 13:05   
Added the following test cases for this problem:

        * php/096l.qa:
        * php/096m.qa:
        * php/096n.qa:
        * php/096o.qa:
        * php/096p.qa:
        * php/096q.qa:
        * php/096r.qa:
        * php/096s.qa:
        * php/396l.qa:
        * php/396m.qa:
        * php/396n.qa:
        * php/396o.qa:
        * php/396p.qa:
        * php/396q.qa:
        * php/396r.qa:
        * php/396s.qa:

I confirmed that this is fixed in the current trunk and gjvc reports
that it is fixed in the most recent snapshot.
(0002690)
mo   
01-28-08 13:06   
Fixed bug reverting static $this patch.