0006211: admin meter graphs are ugly for locales that use a comma as the decimal point

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006211

[Resin]

minor

always

01-19-19 10:52

01-19-19 10:56

Reporter

nam

View Status

public

Assigned To

nam

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

4.0.60

Product Version

4.0.59

Product Build

Summary

0006211: admin meter graphs are ugly for locales that use a comma as the decimal point

Description

(rep by S. Busch)

Most probably it is caused by an environment variable or other locale setting where I run Resin, but I have observed that the meters page in the Resin Administration (php) shows ugly meters and it is because the width was calculated with 266,66 rather than using the . to be 266.66

I have attached a screenshot of this.

I would suggest this minor change in $RESIN_HOME/doc/admin/WEB-INF/php/meters_inc.php lines 51 + 52:

Currently:
$width = 800 / $columns;
$height = $width * 0.66;

I would suggest to use round:
$width = round(800 / $columns);
$height = round($width * 0.66);

This way the width and height will be integers like 267.

Steps To Reproduce

Additional Information

Attached Files

Relationships

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
01-19-19 10:52	nam	New Issue
01-19-19 10:56	nam	Status	new => assigned
01-19-19 10:56	nam	Assigned To	=> nam
01-19-19 10:56	nam	Status	assigned => closed
01-19-19 10:56	nam	Resolution	open => fixed
01-19-19 10:56	nam	Fixed in Version	=> 4.0.60

Mantis 1.0.0rc3[^]

26 total queries executed.
24 unique queries executed.