0005283: HttpStatusHealthCheck with Predicates does not match

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0005283

[Resin]

minor

always

11-20-12 14:08

12-28-12 17:19

Reporter

alex

View Status

public

Assigned To

cowan

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

4.0.34

Product Version

4.0.32

Product Build

Summary

0005283: HttpStatusHealthCheck with Predicates does not match

Description

HealthService._lastResultMap has an entry keyed by HttpStatusHealthCheckImpl not HttpStatusHealthCheck, and getLastResult(HealthCheck) returns null, i.e. different object and equals / hashcode aren't implemented.

_lastResultMap entry:

HttpStatusHealthCheckImpl[http://localhost:8084/test.jsp, [^] http://localhost:8084/test.jsp]=HealthCheckResult[CRITICAL:ping [^] http://localhost:8084/test.jsp [^] failed, status: HTTP/1.0 404 Not Found
Server: Resin/4.0.32
Set-Cookie: JSESSIONID=aaaIbctkLAWtXhzwsWFSt; path=/
Content-Type: text/html; charset=utf-8
Content-Length: 192
Date: Tue, 20 Nov 2012 21:37:30 GMT

]

Please see configuration below.

Steps To Reproduce

Additional Information

<health:CallJmxOperation>
    <objectName>resin:type=IfMBeanEnabled,Host=default,WebApp=/,name=ss-proxy-dispatch</objectName>
    <operation>disable</operation>
    <health:IfHealthCritical healthCheck="${mycheck}"/>
  </health:CallJmxOperation>

<health:HttpStatusHealthCheck ee:Named="mycheck">
    <url-list>http://localhost:8084/test.jsp</url-list> [^]
  </health:HttpStatusHealthCheck>

Attached Files

Relationships

Notes
(0006089) alex 11-20-12 16:10	Note: A handful of HealthChecks delegate to HealthCheckImpl - all of them needs to be checked.

(0006128) cowan 12-28-12 17:19	env/0fcs

Issue History
Date Modified	Username	Field	Change
11-20-12 14:08	alex	New Issue
11-20-12 14:10	alex	Description Updated
11-20-12 16:10	alex	Note Added: 0006089
12-21-12 09:09	cowan	Status	new => assigned
12-21-12 09:09	cowan	Assigned To	=> alex
12-21-12 09:10	cowan	Assigned To	alex => cowan
12-28-12 17:19	cowan	Status	assigned => closed
12-28-12 17:19	cowan	Note Added: 0006128
12-28-12 17:19	cowan	Resolution	open => fixed
12-28-12 17:19	cowan	Fixed in Version	=> 4.0.34

Mantis 1.0.0rc3[^]

32 total queries executed.
27 unique queries executed.