Mantis - Resin
Viewing Issue Advanced Details
5283 minor always 11-20-12 14:08 12-28-12 17:19
alex  
cowan  
normal  
closed 4.0.32  
fixed  
none    
none 4.0.34  
0005283: HttpStatusHealthCheck with Predicates does not match
HealthService._lastResultMap has an entry keyed by HttpStatusHealthCheckImpl not HttpStatusHealthCheck, and getLastResult(HealthCheck) returns null, i.e. different object and equals / hashcode aren't implemented.

_lastResultMap entry:

HttpStatusHealthCheckImpl[http://localhost:8084/test.jsp, [^] http://localhost:8084/test.jsp]=HealthCheckResult[CRITICAL:ping [^] http://localhost:8084/test.jsp [^] failed, status: HTTP/1.0 404 Not Found
Server: Resin/4.0.32
Set-Cookie: JSESSIONID=aaaIbctkLAWtXhzwsWFSt; path=/
Content-Type: text/html; charset=utf-8
Content-Length: 192
Date: Tue, 20 Nov 2012 21:37:30 GMT

]

Please see configuration below.
 <health:CallJmxOperation>
    <objectName>resin:type=IfMBeanEnabled,Host=default,WebApp=/,name=ss-proxy-dispatch</objectName>
    <operation>disable</operation>
    <health:IfHealthCritical healthCheck="${mycheck}"/>
  </health:CallJmxOperation>

 <health:HttpStatusHealthCheck ee:Named="mycheck">
    <url-list>http://localhost:8084/test.jsp</url-list> [^]
  </health:HttpStatusHealthCheck>

Notes
(0006089)
alex   
11-20-12 16:10   
Note: A handful of HealthChecks delegate to HealthCheckImpl - all of them needs to be checked.
(0006128)
cowan   
12-28-12 17:19   
env/0fcs