0000094: cached deserializers are never used in SerializerFactory

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000094

[Resin]

minor

always

04-11-05 00:00

05-11-05 00:00

Reporter

user72

View Status

public

Assigned To

Priority

high

Resolution

fixed

Status

closed

Product Version

3.0.12

Summary

0000094: cached deserializers are never used in SerializerFactory

Description

RSN-85
In com.caucho.hessian.io.SerializerFactory.getDeserializer(String type), there is the following code:

if (_cachedTypeDeserializerMap != null)
  deserializer = (Deserializer) _cachedTypeDeserializerMap.get(type);

deserializer = (Deserializer) _typeMap.get(type);
if (deserializer != null) {
  return deserializer;
}

The deserializer returned from the cache is always overwritten by the one from _typeMap. Should be:

if (_cachedTypeDeserializerMap != null)
  deserializer = (Deserializer) _cachedTypeDeserializerMap.get(type);
if (deserializer == null)
  deserializer = (Deserializer) _typeMap.get(type);
if (deserializer != null) {
  return deserializer;
}

Additional Information

all

Attached Files

Relationships

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
04-11-05 00:00	user72	New Issue
11-30-05 00:00	administrator	Fixed in Version	=> 3.0.13

Mantis 1.0.0rc3[^]

31 total queries executed.
25 unique queries executed.