0003646: Delegate construction of HessianSkeleton's debug PrintWriter to an overridable method

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003646

[Hessian]

minor

always

08-24-09 00:02

12-16-09 15:42

Reporter

Peter Dettman

View Status

public

Assigned To

ferg

Priority

normal

Resolution

fixed

Status

closed

Product Version

4.0.1

Summary

0003646: Delegate construction of HessianSkeleton's debug PrintWriter to an overridable method

Description

see HessianSkeleton in main invoke method.

I've attached a patch that adds a protected method for creating the PrintWriter
when debug mode is enabled.

Additional Information

The Spring HessianExporter ought to be able to simply call HessianSkeleton.invoke(InputStream, OutputStream, SerializerFactory) to handle servlet calls, but debug output would go to the wrong logger if it did this now.

HessianExporter.invoke currently duplicates most of what HessianSkeleton.invoke does. As things stand, I can improve it so that it only duplicates the debug mode handling at the top of invoke. With this patch applied, I could just subclass HessianSkeleton to create the PrintWriter around Spring's logger.

I am of course open to other suggestions for achieving the same result.

Attached Files

Hessian_createDebugPrintWriter.patch [^] (883 bytes) 08-24-09 00:02

Relationships

Notes
(0004342) ferg 12-16-09 15:42	hessian/3558

Issue History
Date Modified	Username	Field	Change
08-24-09 00:02	Peter Dettman	New Issue
08-24-09 00:02	Peter Dettman	File Added: Hessian_createDebugPrintWriter.patch
12-16-09 15:42	ferg	Note Added: 0004342
12-16-09 15:42	ferg	Assigned To	=> ferg
12-16-09 15:42	ferg	Status	new => closed
12-16-09 15:42	ferg	Resolution	open => fixed
12-16-09 15:42	ferg	Fixed in Version	=> 4.0.3

Mantis 1.0.0rc3[^]

30 total queries executed.
26 unique queries executed.