0003105: curl_setopt_array doesn't work for multiple options

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003105

[Quercus]

minor

always

11-29-08 22:05

12-10-08 09:14

Reporter

koreth

View Status

public

Assigned To

nam

Priority

normal

Resolution

fixed

Status

closed

Product Version

3.2.1

Summary

0003105: curl_setopt_array doesn't work for multiple options

Description

Trivial fix for a bug in curl_setopt_array; it returns after the first option is set on the underlying resource:

--- a/modules/quercus/src/com/caucho/quercus/lib/curl/CurlModule.java
+++ b/modules/quercus/src/com/caucho/quercus/lib/curl/CurlModule.java
@@ -642,7 +642,7 @@ public class CurlModule
       return BooleanValue.FALSE;

     for (Map.Entry<Value,Value> entry: options.entrySet()) {
- if (setOption(env, curl, entry.getKey().toInt(), entry.getValue()))
+ if (!setOption(env, curl, entry.getKey().toInt(), entry.getValue()))
         return BooleanValue.FALSE;
     }

Additional Information

Attached Files

Relationships

Notes
(0003586) nam 12-10-08 09:14	php/5042

Issue History
Date Modified	Username	Field	Change
11-29-08 22:05	koreth	New Issue
12-08-08 10:39	nam	Status	new => assigned
12-08-08 10:39	nam	Assigned To	=> nam
12-10-08 09:14	nam	Status	assigned => closed
12-10-08 09:14	nam	Note Added: 0003586
12-10-08 09:14	nam	Resolution	open => fixed
12-10-08 09:14	nam	Fixed in Version	=> 4.0.0

Mantis 1.0.0rc3[^]

29 total queries executed.
26 unique queries executed.