0002608: GZip filter messes up http headers

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002608

[Resin]

major

always

04-16-08 06:16

04-21-08 10:27

Reporter

azenkov

View Status

public

Assigned To

ferg

Priority

urgent

Resolution

fixed

Status

closed

Product Version

3.1.5

Summary

0002608: GZip filter messes up http headers

Description

The problem is in logic of caucho GZip filter which sets http headers.
1. It sets Vary header on those requests which it shouldn't touch according to <allow-content-type> configuration. Which is just a bug I believe. Simply speaking if you restrict gzip filter by content type and map it to all requests every single request will get Vary not just these which were gziped. This bug makes impossible to fine tune gzip filter.
2. If you disable Vary for gzip filter with use-vary parameter for some reason it sets Cache-control: private header which is not related to Vary header. Already set Cache-control: private in its turn doesn't allow resin cache mappings to set proper expiration on static resources.

Additional Information

Please let me know if I should post those 2 as separate issues but I think they worth fixing in a batch.

Attached Files

Relationships

Notes
(0002997) sam 04-18-08 09:09	For 2), Resin set's the Cache-control: private if use-vary=false because otherwise browsers that do not accept gzip could get a gzipped response served to them out of the cache. use-vary is a bit of a legacy configuration, it is intended to workaround an IE bug that causes IE to never cache responses that set the Vary header. A better way to solve that issue is to use rewrite-vary-as-private=true in the <cache> configuration. That way the gzipped response is still stored in Resin's proxy cache, and browsers will get Cache-Control: private instead of Vary: Accept-Encoding More informatrion about the IE problem with Vary is here: http://bugs.caucho.com/view.php?id=1581 [^] Documentation for rewrite-vary-as-private is here: http://www.caucho.com/resin/doc/cluster-tags.xtp#cache [^]

(0002999) ferg 04-21-08 10:27	server/183q

Issue History
Date Modified	Username	Field	Change
04-16-08 06:16	azenkov	New Issue
04-16-08 15:28	azenkov	Issue Monitored: azenkov
04-18-08 08:55	sam	Priority	normal => urgent
04-18-08 09:09	sam	Note Added: 0002997
04-21-08 10:27	ferg	Note Added: 0002999
04-21-08 10:27	ferg	Assigned To	=> ferg
04-21-08 10:27	ferg	Status	new => closed
04-21-08 10:27	ferg	Resolution	open => fixed
04-21-08 10:27	ferg	Fixed in Version	=> 3.1.6

Mantis 1.0.0rc3[^]

33 total queries executed.
28 unique queries executed.