0000103: JMS with JDBC on PostgreSQL

(0000117)
user125
04-14-05 00:00

I have downloaded the resin code and started looking into it.
First of all it seems the exception I reported is originated from a wrong piece of code. Let me explain:
The com.caucho.jms.jdbc.JdbcMessage.send() method does something like this:

public long send(Message message, int queue, long expireTime)
    throws SQLException, IOException, JMSException
  {
  ........
   if (_messageSequence != null) {//which should be the case for PostgreSQL
        .....
        pstmt.setBinaryStream(i++, header.openRead(), header.getLength());

        ......
   } else {//for databases that support auto-increment columns
        ...........
        pstmt.setBinaryStream(i++, header.openRead(), header.getLength());//this is where my exception comes from
        .......
   }


So, the first thing that I found interesting is that the flow goes on the wrong case (the else branch). The second thing is why header.getLength() returns a negative integer in this case. I suspect that it would throw the same kind of exception if it would go on the if branch.

For the first thing I think I have actually found the cause: the _messageSequence is initialized in the init method, which does something like this:

public void init() throws ConfigException, SQLException {
    ...............
    Statement stmt = conn.createStatement();
    String sql = "SELECT 1 FROM " + _messageTable + " WHERE 1=0";

    try {
        ResultSet rs = stmt.executeQuery(sql);
        rs.next();
        rs.close();
        stmt.close();

        return;//the method will return here after the resin_jms_message is created in the database.
    } catch (SQLException e) {
    log.finest(e.toString());
    }
    ..............
    JdbcMetaData metaData = _jdbcManager.getMetaData();
    String identity = "";
    if (metaData.supportsIdentity()){
        identity = " auto_increment";
    }else{
        _messageSequence = _messageTable + "_cseq";
    }
    .........
}

First time when I started Resin, it created the 'resin_jms_message' table in the database. After I restarted Resin,
the table is already in the database and the 'SELECT 1 FROM resin_jms_message WHERE 1=0' actually executes with
success. So, the init method simply returns, and the _messageSequence does get to be initialized properly.

I will investigate more for the second issue, the java.lang.NegativeArraySizeException.

I would appreciate some feedback and maybe some hints.

Mircea

(0000118)
user125
04-14-05 00:00

Hi, I have changed the JdbcMessage class as I said in comment 2, and everythinmg seems to work. Here is the modified init() method:
public void init()
    throws ConfigException, SQLException
  {
    _messageTable = _jdbcManager.getMessageTable();
    _dataSource = _jdbcManager.getDataSource();
JdbcMetaData metaData = _jdbcManager.getMetaData();

      String identity = "";

      if (metaData.supportsIdentity())
    identity = " auto_increment";
      else
    _messageSequence = _messageTable + "_cseq";

    Connection conn = _dataSource.getConnection();
    try {
      Statement stmt = conn.createStatement();
      String sql = "SELECT 1 FROM " + _messageTable + " WHERE 1=0";

      try {
    ResultSet rs = stmt.executeQuery(sql);
    rs.next();
    rs.close();
    stmt.close();

    return;
      } catch (SQLException e) {
    log.finest(e.toString());
      }

      String blob = _jdbcManager.getBlob();
      String longType = _jdbcManager.getLongType();

      log.info(L.l("creating JMS message table {0}", _messageTable));



      sql = ("CREATE TABLE " + _messageTable + " (" +
         " m_id " + longType + " PRIMARY KEY" + identity + "," +
         " queue INTEGER NOT NULL," +
         " connection VARCHAR(255)," +
         " consumer " + longType + "," +
         " delivered INTEGER NOT NULL," +
         " msg_type INTEGER NOT NULL," +
         " expire " + longType + " NOT NULL," +
         " header " + blob + "," +
         " body " + blob +
         ")");

      stmt.executeUpdate(sql);

      if (_messageSequence != null) {
    stmt.executeUpdate(metaData.createSequenceSQL(_messageSequence, 1));
      }
    } finally {
      conn.close();
    }
  }

I plan to use this JMS + JDBC feature on PostgreSQL a project I am working on right now. It is just a small change and I hope it can be included in the next Resin release. I am just curious what is the date of the next relesease, because we have a tight deadline on the project, and lots of things are dependent on this feature.

(0000119)
ferg
04-14-05 00:00

ejb/6790

thanks for all the work looking into this.

Issue History
Date Modified	Username	Field	Change
04-14-05 00:00	user125	New Issue
11-30-05 00:00	administrator	Fixed in Version	=> 3.0.13

Notes
(0000117) user125 04-14-05 00:00	I have downloaded the resin code and started looking into it. First of all it seems the exception I reported is originated from a wrong piece of code. Let me explain: The com.caucho.jms.jdbc.JdbcMessage.send() method does something like this: public long send(Message message, int queue, long expireTime) throws SQLException, IOException, JMSException { ........ if (_messageSequence != null) {//which should be the case for PostgreSQL ..... pstmt.setBinaryStream(i++, header.openRead(), header.getLength()); ...... } else {//for databases that support auto-increment columns ........... pstmt.setBinaryStream(i++, header.openRead(), header.getLength());//this is where my exception comes from ....... } So, the first thing that I found interesting is that the flow goes on the wrong case (the else branch). The second thing is why header.getLength() returns a negative integer in this case. I suspect that it would throw the same kind of exception if it would go on the if branch. For the first thing I think I have actually found the cause: the _messageSequence is initialized in the init method, which does something like this: public void init() throws ConfigException, SQLException { ............... Statement stmt = conn.createStatement(); String sql = "SELECT 1 FROM " + _messageTable + " WHERE 1=0"; try { ResultSet rs = stmt.executeQuery(sql); rs.next(); rs.close(); stmt.close(); return;//the method will return here after the resin_jms_message is created in the database. } catch (SQLException e) { log.finest(e.toString()); } .............. JdbcMetaData metaData = _jdbcManager.getMetaData(); String identity = ""; if (metaData.supportsIdentity()){ identity = " auto_increment"; }else{ _messageSequence = _messageTable + "_cseq"; } ......... } First time when I started Resin, it created the 'resin_jms_message' table in the database. After I restarted Resin, the table is already in the database and the 'SELECT 1 FROM resin_jms_message WHERE 1=0' actually executes with success. So, the init method simply returns, and the _messageSequence does get to be initialized properly. I will investigate more for the second issue, the java.lang.NegativeArraySizeException. I would appreciate some feedback and maybe some hints. Mircea

(0000118) user125 04-14-05 00:00	Hi, I have changed the JdbcMessage class as I said in comment 2, and everythinmg seems to work. Here is the modified init() method: public void init() throws ConfigException, SQLException { _messageTable = _jdbcManager.getMessageTable(); _dataSource = _jdbcManager.getDataSource(); JdbcMetaData metaData = _jdbcManager.getMetaData(); String identity = ""; if (metaData.supportsIdentity()) identity = " auto_increment"; else _messageSequence = _messageTable + "_cseq"; Connection conn = _dataSource.getConnection(); try { Statement stmt = conn.createStatement(); String sql = "SELECT 1 FROM " + _messageTable + " WHERE 1=0"; try { ResultSet rs = stmt.executeQuery(sql); rs.next(); rs.close(); stmt.close(); return; } catch (SQLException e) { log.finest(e.toString()); } String blob = _jdbcManager.getBlob(); String longType = _jdbcManager.getLongType(); log.info(L.l("creating JMS message table {0}", _messageTable)); sql = ("CREATE TABLE " + _messageTable + " (" + " m_id " + longType + " PRIMARY KEY" + identity + "," + " queue INTEGER NOT NULL," + " connection VARCHAR(255)," + " consumer " + longType + "," + " delivered INTEGER NOT NULL," + " msg_type INTEGER NOT NULL," + " expire " + longType + " NOT NULL," + " header " + blob + "," + " body " + blob + ")"); stmt.executeUpdate(sql); if (_messageSequence != null) { stmt.executeUpdate(metaData.createSequenceSQL(_messageSequence, 1)); } } finally { conn.close(); } } I plan to use this JMS + JDBC feature on PostgreSQL a project I am working on right now. It is just a small change and I hope it can be included in the next Resin release. I am just curious what is the date of the next relesease, because we have a tight deadline on the project, and lots of things are dependent on this feature.

(0000119) ferg 04-14-05 00:00	ejb/6790 thanks for all the work looking into this.

Relationships