0001178: set_time_limit() doesn't allow removing time limit

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001178

[Quercus]

minor

always

06-05-06 17:49

06-09-06 14:39

Reporter

koreth

View Status

public

Assigned To

ferg

Priority

normal

Resolution

fixed

Status

closed

Product Version

3.0.20

Summary

0001178: set_time_limit() doesn't allow removing time limit

Description

The PHP docs say "set_time_limit(0);" is supposed to remove the timeout for script execution; in Quercus this results in the time limit expiring immediately.

The fix is trivial, just adding a check for a 0 time limit in checkTimeout():

  public final void checkTimeout()
  {
    if (_timeLimit != 0) {
      long now = Alarm.getCurrentTime();

      if (_startTime + _timeLimit < now)
        throw new QuercusRuntimeException(L.l("script timed out"));
    }
  }

Additional Information

Attached Files

Relationships

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
06-05-06 17:49	koreth	New Issue
06-09-06 14:39	ferg	Assigned To	=> ferg
06-09-06 14:39	ferg	Status	new => closed
06-09-06 14:39	ferg	Resolution	open => fixed
06-09-06 14:39	ferg	Fixed in Version	=> 3.0.20

Mantis 1.0.0rc3[^]

27 total queries executed.
25 unique queries executed.