0006289: sessions are not saved to persistent storage for jsp pages with c:import tag

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006289

[Resin]

minor

always

10-02-19 10:45

10-03-19 16:48

Reporter

nam

View Status

public

Assigned To

ferg

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

4.0.63

Product Version

4.0.62

Product Build

Summary

0006289: sessions are not saved to persistent storage for jsp pages with c:import tag

Description

(rep by alpor9)

Problem appears if there is <c:import> tag in the target page.

If page contains any such import, any session manipulations on that page will not be saved to persistent storage.

Because import request clears _isModified flag in SessionImpl#load() (see line 725 in SessionImpl.java for 4.0.48).

And then, the subsequent SessionImpl#save() method (after the main page request) sees nothing to save. And 4.0.62 has the same logic there.

Steps To Reproduce

Additional Information

Steps to reproduce:
1. view.jsp => see that attribute is null
2. save.jsp
3. view.jsp => see that attribute is "bar"
4. remove.jsp
5. view.jsp => see that attribute is null
6. restart resin
7. view.jsp => see that attribute is "bar"
8. remove_no_import.jsp
9. view.jsp => see that attribute is null
10 restart resin
11. view.jsp => see that attribute is null

save.jsp
======
<%

request.getSession().setAttribute("foo", "bar");

%>

view.jsp
======
<%

out.println("foo=" + request.getSession().getAttribute("foo"));

%>

remove.jsp
========
<%@ taglib prefix='c' uri='http://java.sun.com/jsp/jstl/core' [^] %>
<c:import url="view.jsp">

<%

request.getSession().removeAttribute("foo");

%>

remove_no_import.jsp
================
<%

request.getSession().removeAttribute("foo");

%>

Attached Files

Relationships

Notes
(0006917) ferg 10-03-19 16:27	jsp/1cq0

Issue History
Date Modified	Username	Field	Change
10-02-19 10:45	nam	New Issue
10-02-19 11:00	nam	Summary	sessions are not saved for jsp pages with import tag => sessions are not saved for jsp pages with c:import tag
10-02-19 11:08	nam	Description Updated
10-03-19 00:14	nam	Additional Information Updated
10-03-19 00:14	nam	Additional Information Updated
10-03-19 00:18	nam	Summary	sessions are not saved for jsp pages with c:import tag => sessions are not saved to persistent storage for jsp pages with c:import tag
10-03-19 16:27	ferg	Note Added: 0006917
10-03-19 16:27	ferg	Assigned To	=> ferg
10-03-19 16:27	ferg	Status	new => assigned
10-03-19 16:27	ferg	Resolution	open => fixed
10-03-19 16:27	ferg	Fixed in Version	=> 4.0.63
10-03-19 16:48	nam	Status	assigned => closed

Mantis 1.0.0rc3[^]

32 total queries executed.
26 unique queries executed.