0005874: incomplete war extraction

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0005874

[Resin]

minor

always

03-29-15 18:08

03-31-15 15:55

Reporter

alex

View Status

public

Assigned To

ferg

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

4.0.44

Product Version

4.0.42

Product Build

Summary

0005874: incomplete war extraction

Description

rep by alpor9 at google groups

problem was in the non-ASCII file names in the war file.
Git-related code assumed single-byte ASCII encoding of file names in war.
As a result the non-ASCII file names has been corrupted causing errors when writing files to disk.

GitSystem#expandToPath() - added catch clause to log exceptions.
GitWorkingTree#writeTree() and GitObjectStream#parseTree() - multibyte encoding support added when writing and reading file names: string -> byte array and byte array -> string instead of working with single bytes, assuming that bytes are chars.

Steps To Reproduce

Additional Information

Attached Files

Relationships

Notes
(0006615) ferg 03-31-15 15:55	server/1h7w

Issue History
Date Modified	Username	Field	Change
03-29-15 18:08	alex	New Issue
03-31-15 15:55	ferg	Note Added: 0006615
03-31-15 15:55	ferg	Assigned To	=> ferg
03-31-15 15:55	ferg	Status	new => closed
03-31-15 15:55	ferg	Resolution	open => fixed
03-31-15 15:55	ferg	Fixed in Version	=> 4.0.44

Mantis 1.0.0rc3[^]

29 total queries executed.
26 unique queries executed.