0005536: webapp deploy will delete files in symbolic links with expand-preserve-fileset enable

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0005536

[Resin]

major

always

09-28-13 21:16

10-03-13 10:46

Reporter

ssmax

View Status

public

Assigned To

ferg

Priority

normal

Resolution

fixed

Platform

Linux

Status

closed

Centos

Projection

none

OS Version

5.x,6.x

ETA

none

Fixed in Version

4.0.38

Product Version

4.0.38

Product Build

Summary

0005536: webapp deploy will delete files in symbolic links with expand-preserve-fileset enable

Description

default config in resin.xml

      <web-app-deploy path="webapps"
                      expand-preserve-fileset="WEB-INF/work/**"
                      multiversion-routing="${webapp_multiversion_routing}"
                      path-suffix="${elastic_webapp?resin.id:''}"/>

expand-preserve-fileset="WEB-INF/work/**"
this feature will preserve the files in WEB-INF/work/, but with this feature enable, if there are some symbolic links in the war, resin will delete all files under symbolic links when the war deploy...

if disable this feature, delete the line ' expand-preserve-fileset="WEB-INF/work/**" ' in the config, resin will only delete the files under webapp but leave all files under symbolic links.

i guess this feature first make a file list and filter it, so it found the files under symbolic links and delete it , it is not safe because even 'rm -rf ' will not follow the symbolic links.

Steps To Reproduce

put a war in webapps/test.war
it deploy as webapps/test/
ln -s /home/xxx webapps/test/xxx
redeploy test.war
all files in /home/xxx will be deleted, and they are deleted by watchdog , always start with root.

Additional Information

Attached Files

Relationships

Notes
(0006328) ferg 10-03-13 10:46	server/1hc4

Issue History
Date Modified	Username	Field	Change
09-28-13 21:16	ssmax	New Issue
10-03-13 10:46	ferg	Note Added: 0006328
10-03-13 10:46	ferg	Assigned To	=> ferg
10-03-13 10:46	ferg	Status	new => closed
10-03-13 10:46	ferg	Resolution	open => fixed
10-03-13 10:46	ferg	Fixed in Version	=> 4.0.38

Mantis 1.0.0rc3[^]

29 total queries executed.
26 unique queries executed.