0005459: Resin 7 websocket API issue

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0005459

[Resin]

minor

always

06-14-13 11:15

07-23-13 10:51

Reporter

rickHigh

View Status

public

Assigned To

ferg

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

7.0.0

Product Version

Product Build

Summary

0005459: Resin 7 websocket API issue

Description

JampServlet is looking for Upgrade="WebSocket".
It should be looking for the header Upgrade="websockt"

This causes HTML 5 clients (JavaScript, Dart) to get a 404 in the Resin log when trying to call into JAMP.

It is a minor change.

@WebServlet(asyncSupported=true)
public class JampServlet extends WebSocketServletImpl
{

req.getHeader("Upgrade") is returning "websocket".

This is what the spec says it should return.

We are incorrectly expecting "WebSocket".

@Override
  public void service(ServletRequest request, ServletResponse response)
    throws IOException, ServletException
  {
    HttpServletRequestImpl req = (HttpServletRequestImpl) request;
    HttpServletResponseImpl res = (HttpServletResponseImpl) response;

    if ("WebSocket".equals(req.getHeader("Upgrade"))) {
      super.service(request, response);
      return;
    }

should be changed to

    if ("websocket".equals(req.getHeader("Upgrade"))) {
      super.service(request, response);
      return;
    }

Steps To Reproduce

Additional Information

Attached Files

Relationships

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
06-14-13 11:15	rickHigh	New Issue
07-23-13 10:51	ferg	Assigned To	=> ferg
07-23-13 10:51	ferg	Status	new => closed
07-23-13 10:51	ferg	Resolution	open => fixed
07-23-13 10:51	ferg	Fixed in Version	=> 7.0.0

Mantis 1.0.0rc3[^]

27 total queries executed.
25 unique queries executed.