Mantis Bugtracker

Viewing Issue Advanced Details Jump to Notes ] View Simple ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004719 [Resin] minor always 08-18-11 12:38 08-23-11 13:38
Reporter brandonkearby View Status public  
Assigned To ferg
Priority normal Resolution fixed Platform
Status closed   OS
Projection none   OS Version
ETA none Fixed in Version 4.0.22 Product Version 4.0.15
  Product Build
Summary 0004719: QueryString parameters are in reverse order on <jsp:include and <jsp:forward
Description When passing parameters in a <jsp:include, the parameter order is reversed when calling request.getParameters("foo").

For example:

<jsp:include page="/views/shared/_header.jsp">
    <jsp:param name="jsFile" value="gallery/photoUpload.js"/>
    <jsp:param name="jsFile" value="ugc/discussions.js"/>
    <jsp:param name="jsFile" value="livepipe.js"/>
    <jsp:param name="jsFile" value="widget/textArea.js"/>
    <jsp:param name="jsFile" value="webtoolkit.js"/>

After the previous include:
 request.getParameters("jsFile") is returning the values in reverse order: webtoolkit.js, widget/textArea.js, livepipe.js, ...

The desired behavior for is request.getParameters("jsFile") is: gallery/photoUpload.js, ugc/discussions, livepipe.js, ...

Steps To Reproduce
Additional Information After looking at the source, I noticed that the code for a jsp:include is trying to push them in front of the querystring params of the top level request. Attached is a patch that will do that as well as preserve the order defined in a jsp:include.
Attached Files  Preserve_QueryString_parameter_order_for_non_top_level_requests_(jsp_include_and_forwards).patch [^] (3,077 bytes) 08-18-11 12:38

- Relationships

- Notes
08-23-11 13:38


- Issue History
Date Modified Username Field Change
08-18-11 12:38 brandonkearby New Issue
08-18-11 12:38 brandonkearby File Added: Preserve_QueryString_parameter_order_for_non_top_level_requests_(jsp_include_and_forwards).patch
08-23-11 13:38 ferg Note Added: 0005457
08-23-11 13:38 ferg Assigned To  => ferg
08-23-11 13:38 ferg Status new => closed
08-23-11 13:38 ferg Resolution open => fixed
08-23-11 13:38 ferg Fixed in Version  => 4.0.22

Mantis 1.0.0rc3[^]
Copyright © 2000 - 2005 Mantis Group
30 total queries executed.
26 unique queries executed.
Powered by Mantis Bugtracker