0004077: NPE in Env during cleanup

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0004077

[Quercus]

minor

always

06-12-10 04:07

07-09-10 07:38

Reporter

domdorn

View Status

public

Assigned To

domdorn

Priority

normal

Resolution

fixed

Platform

Status

resolved

Projection

none

OS Version

ETA

none

Fixed in Version

Product Version

4.0.9

Product Build

Summary

0004077: NPE in Env during cleanup

Description

it is possible to generate a NPE in Env.java in the cleanup method:

    AbstractFunction []fun = _fun;
    _fun = null;
    if (fun != null) {
      boolean isUsed = false;

      if (_page.setRuntimeFunction(fun)) {
        isUsed = true;
      }

here it is not checked if _page is null, which could be the case if the Class is created with the Constructor(QuercusContext) where everything except the context is null.

I propose to change the line to
      if (_page != null && _page.setRuntimeFunction(fun)) {

Steps To Reproduce

Additional Information

Attached Files

Relationships

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
06-12-10 04:07	domdorn	New Issue
07-09-10 07:08	domdorn	Assigned To	=> domdorn
07-09-10 07:08	domdorn	Status	new => assigned
07-09-10 07:38	domdorn	Status	assigned => resolved
07-09-10 07:38	domdorn	Resolution	open => fixed
07-09-10 07:38	domdorn	version	=> 4.0.9

Mantis 1.0.0rc3[^]

27 total queries executed.
25 unique queries executed.