0003921: SerializerFactory doesn't return the correct deserializer

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003921

[Hessian]

major

always

02-27-10 21:03

02-27-10 21:09

Reporter

aloksingh

View Status

public

Assigned To

Priority

normal

Resolution

open

Platform

Status

new

Projection

none

OS Version

ETA

none

Fixed in Version

Product Version

4.0.3

Product Build

Summary

0003921: SerializerFactory doesn't return the correct deserializer

Description

In the class SerializerFactory, loadDeserializer() methods skips the deserializer returned from _factories..

Here is the current code, note the line "deserializer = factory.getDeserializer(cl);"
The reference is not being returned from the method, and instead overwritten a couple of lines later.
[code]
protected Deserializer loadDeserializer(Class cl)
    throws HessianProtocolException
  {
    Deserializer deserializer = null;

    for (int i = 0;
         deserializer == null && _factories != null && i < _factories.size();
         i++) {
      AbstractSerializerFactory factory;
      factory = (AbstractSerializerFactory) _factories.get(i);

      deserializer = factory.getDeserializer(cl);
    }

    // XXX: need test
    deserializer = _contextFactory.getDeserializer(cl.getName());

    if (deserializer != null)
      return deserializer;

[/code]

Instead, it should be something like this
[code]
deserializer = factory.getDeserializer(cl);
if (deserializer != null)
      return deserializer;
    }
[/code]

Steps To Reproduce

Additional Information

Attached Files

Relationships

Notes
(0004449) aloksingh 02-27-10 21:09	Related to 3632

Issue History
Date Modified	Username	Field	Change
02-27-10 21:03	aloksingh	New Issue
02-27-10 21:09	aloksingh	Note Added: 0004449
02-27-10 21:09	aloksingh	Issue Monitored: aloksingh

Mantis 1.0.0rc3[^]

29 total queries executed.
25 unique queries executed.