0003686: hmux chunking issues with 4.0.1

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003686

[Resin]

minor

always

09-16-09 11:17

10-29-09 16:04

Reporter

ferg

View Status

public

Assigned To

ferg

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

4.0.2

Product Version

4.0.1

Product Build

Summary

0003686: hmux chunking issues with 4.0.1

Description

(rep by Wesley Wu)

affected version: Resin 4.0.0 & 4.0.1
reproducible: every time

HmuxResponse.writeHeadersInt should not always return false, otherwise in ResponseStream "write-chunk5" will never happen if _chunkedEncoding==false.

this result in UTF8Writer produces a reproducible error.

I modified HmuxResponse.writeHeadersInt to add some lines below:

        // add by wesley start
        boolean hasContentLength = false;
        // add by wesley end
        if (_contentLength >= 0) {
            cb.clear();
            cb.append(_contentLength);
            _req.writeHeader("Content-Length", cb);
            // add by wesley start
            hasContentLength = true;
            // add by wesley end
        } else if (length >= 0) {
            cb.clear();
            cb.append(length);
            _req.writeHeader("Content-Length", cb);
            // add by wesley start
            hasContentLength = true;
            // add by wesley end
        }

                ...

        // add by wesley start
        boolean isChunked = false;
        if (!hasContentLength && !isHead) {
            isChunked = true;
        }
        return isChunked;
        // add by wesley start
          }

and everything goes fine.

Steps To Reproduce

Additional Information

Attached Files

Relationships

Notes
(0004273) ferg 10-29-09 16:04	chunking implementation redesigned in 4.0.2.

Issue History
Date Modified	Username	Field	Change
09-16-09 11:17	ferg	New Issue
10-29-09 16:04	ferg	Note Added: 0004273
10-29-09 16:04	ferg	Assigned To	=> ferg
10-29-09 16:04	ferg	Status	new => closed
10-29-09 16:04	ferg	Resolution	open => fixed
10-29-09 16:04	ferg	Fixed in Version	=> 4.0.2

Mantis 1.0.0rc3[^]

28 total queries executed.
25 unique queries executed.