0003267: Patch: Fail to build Fedora-10 package on direct use of ld in makefile

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003267

[Resin]

trivial

always

01-15-09 13:13

01-26-09 08:54

Reporter

dicr

View Status

public

Assigned To

ferg

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

4.0.0

Product Version

4.0.0

Product Build

Summary

0003267: Patch: Fail to build Fedora-10 package on direct use of ld in makefile

Description

+ /usr/lib/rpm/find-debuginfo.sh --strict-build-id /home/dicr/rpmbuild/BUILD/resin-pro-4.0.s090115
extracting debug info from /var/tmp/resin-4.0-root/usr/lib/resin/libresin.so
*** ERROR: No build ID note found in /var/tmp/resin-4.0-root/usr/lib/resin/libresin.so

This problem is described at: http://www.redhat.com/archives/fedora-maintainers/2007-August/msg00135.html [^]

"packagers note: do not run ld directly

e.g. a makefile line:

    $(LD) -shared -o $@ $(objs)

should be:

    $(CC) -shared -o $@ $(objs)

Best practice is to use consistently the flags otherwise passed to
the compiler, and also use LDFLAGS, i.e.:

    $(CC) $(CFLAGS) $(LDFLAGS) -shared -o $@ $(objs)
"

Steps To Reproduce

Additional Information

Patch-file is attached to this report.

Attached Files

resin-4.0.patch [^] (2,385 bytes) 01-15-09 13:13

Relationships

Notes
(0003778) ferg 01-26-09 08:54	Thanks!

Issue History
Date Modified	Username	Field	Change
01-15-09 13:13	dicr	New Issue
01-15-09 13:13	dicr	File Added: resin-4.0.patch
01-26-09 08:54	ferg	Note Added: 0003778
01-26-09 08:54	ferg	Assigned To	=> ferg
01-26-09 08:54	ferg	Status	new => closed
01-26-09 08:54	ferg	Resolution	open => fixed
01-26-09 08:54	ferg	Fixed in Version	=> 4.0.0

Mantis 1.0.0rc3[^]

30 total queries executed.
26 unique queries executed.