0002607: StringBuilderValuer.append(Reader reader, long length) fails with IndexOutOfBoundsException

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002607

[Quercus]

major

always

04-15-08 07:41

04-16-08 10:29

Reporter

sgraf

View Status

public

Assigned To

nam

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

3.1.6

Product Version

3.1.6

Product Build

Latest SVN Build

Summary

0002607: StringBuilderValuer.append(Reader reader, long length) fails with IndexOutOfBoundsException

Description

At line 1176

int sublen = Math.min(8192, (int)length);

Will cast length to int but lenght is a long and this cast may result in a negative integer which in turn will be smaller then 8192.

To correct this proble change this line to

int sublen = (int) Math.min(8192L, length);

Path file is attached.

Steps To Reproduce

Call StringBuilderValuer.append(Reader reader, long length) with a long value larger them Integer.MAX_VALUE

Example:

StringBuilderValuer.append(reader, Long.MAX_VALUE)

Additional Information

Related to issue 0002026

Attached Files

StringBuilderValue.java.diff [^] (501 bytes) 04-15-08 07:41

Relationships

Notes
(0002973) sgraf 04-15-08 07:42	In fact Additional Information should say: Related to issue 0002606 Would be nice to have an edit button ;-)

(0002982) nam 04-16-08 10:29	php/4409

Issue History
Date Modified	Username	Field	Change
04-15-08 07:41	sgraf	New Issue
04-15-08 07:41	sgraf	File Added: StringBuilderValue.java.diff
04-15-08 07:42	sgraf	Note Added: 0002973
04-16-08 06:47	nam	Status	new => assigned
04-16-08 06:47	nam	Assigned To	=> nam
04-16-08 10:29	nam	Status	assigned => closed
04-16-08 10:29	nam	Note Added: 0002982
04-16-08 10:29	nam	Resolution	open => fixed
04-16-08 10:29	nam	Fixed in Version	=> 3.1.6

Mantis 1.0.0rc3[^]

34 total queries executed.
29 unique queries executed.