0002583: NPE from AbstractHttpResponse.writeHeaders() when calling NamedDispatcherImp.include()

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002583

[Resin]

major

always

04-09-08 08:29

04-09-08 15:00

Reporter

katjak

View Status

public

Assigned To

ferg

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

3.0.26

Product Version

3.0.25

Product Build

Summary

0002583: NPE from AbstractHttpResponse.writeHeaders() when calling NamedDispatcherImp.include()

Description

We get this with Resin 3.0.24 and 3.0.25, but not with 3.0.19 or other servlet containers:

java.lang.NullPointerException
    at com.caucho.server.connection.AbstractHttpResponse.writeHeaders(AbstractHttpResponse.java:1585)
    at com.caucho.server.connection.IncludeResponseStream.writeNext(IncludeResponseStream.java:244)
    at com.caucho.server.connection.ToByteResponseStream.flushByteBuffer(ToByteResponseStream.java:518)
    at com.caucho.server.connection.ToByteResponseStream.flushBuffer(ToByteResponseStream.java:424)
    at com.caucho.server.connection.IncludeResponseStream.finish(IncludeResponseStream.java:301)
    at com.caucho.server.connection.AbstractHttpResponse.finish(AbstractHttpResponse.java:1988)
    at com.caucho.server.connection.AbstractHttpResponse.finish(AbstractHttpResponse.java:1957)
    at com.caucho.server.webapp.NamedDispatcherImpl.include(NamedDispatcherImpl.java:85)
    at foo.bar.DispatchFilter.dispatch(DispatchFilter.java:138)

Looking at the code between different versions, it seems that AbstractHttpResponse.writeHeaders() has been rewritten, and either the _originalRequest attribute doesn't get set like it should when using include() instead of forward(), or there should be a null check for _originalRequest in writeHeaders method.

Steps To Reproduce

Additional Information

Attached Files

Relationships

Notes
(0002953) ferg 04-09-08 15:00	server/10ju

Issue History
Date Modified	Username	Field	Change
04-09-08 08:29	katjak	New Issue
04-09-08 08:36	katjak	Issue Monitored: katjak
04-09-08 15:00	ferg	Note Added: 0002953
04-09-08 15:00	ferg	Assigned To	=> ferg
04-09-08 15:00	ferg	Status	new => closed
04-09-08 15:00	ferg	Resolution	open => fixed
04-09-08 15:00	ferg	Fixed in Version	=> 3.0.26

Mantis 1.0.0rc3[^]

30 total queries executed.
26 unique queries executed.