0002141: phpBB2 doesn't work anymore with Resin 3.1.3 Pro and non-Pro

(0002458)
rsouissi
11-07-07 09:57

I found out this problem happens because I had this parameter added to my web.xml:

    <init-param>
      <param-name>script-encoding</param-name>
      <param-value>windows-1256</param-value>
    </init-param>

I needed this encoding to support Arabic pages and it used to work in 3.1.2 Non-Pro version.

(0002472)
mo
11-09-07 18:27

Hello rsouissi

I just tested with phpBB 2.0.22 using the current dev version, the
3.1.3 release and the dev snapshot from 2007/11/06. I was not able
to run phpBB with the 3.1.3 release, but it works for me with the
current dev version and with the snapshot release. Could you do me
a favor and download the snapshot and rerun your test to verify that
this bug is fixed?

http://caucho.com/download/resin-3_1-snap.zip [^]

thanks
Mo

(0002475)
rsouissi
11-10-07 09:56

Hi,

Yes, I tried the latest snapshot (11/06) and the same problem happens.
Did you add this to web.xml ?

    <init-param>
      <param-name>script-encoding</param-name>
      <param-value>iso-8859-6</param-value>
    </init-param>
    <init-param>
      <param-name>compile</param-name>
      <param-value>true</param-value>
    </init-param>

For the encoding, you can try iso-8859-6 and windows-1256, both will fail the same way. This used to work in 3.1.2

(0002477)
mo
11-10-07 16:40

Ahh, I am now able to reproduce the problem. Thanks
for following up. The minimal test case for this issue
is:

WEB-INF/resin-web.xml:

<web-app xmlns="http://caucho.com/ns/resin"> [^]
   <servlet servlet-name="resin-php"
               servlet-class="com.caucho.quercus.servlet.QuercusServlet">
    <init>
      <script-encoding>iso-8859-6</script-encoding>
    </init>
   </servlet>

   <servlet-mapping url-pattern="*.php" servlet-name="resin-php"/>
</web-app>

test/php:

<?php
/**/
echo OK;
?>

This generates:

.../script_encoding/test.php:2: '*' is
an unexpected token, expected an expression. in
test.php:1: <?php
test.php:2: /**/
test.php:3: echo OK;

Added regression test:

php\0j19.qa

(0002486)
nam
11-13-07 19:07

php/001b

Issue History
Date Modified	Username	Field	Change
11-05-07 08:30	rsouissi	New Issue
11-07-07 09:57	rsouissi	Note Added: 0002458
11-09-07 18:27	mo	Note Added: 0002472
11-10-07 09:56	rsouissi	Note Added: 0002475
11-10-07 16:40	mo	Note Added: 0002477
11-10-07 19:32	nam	Status	new => assigned
11-10-07 19:32	nam	Assigned To	=> nam
11-13-07 19:07	nam	Status	assigned => closed
11-13-07 19:07	nam	Note Added: 0002486
11-13-07 19:07	nam	Resolution	open => fixed
11-13-07 19:07	nam	Fixed in Version	=> 3.1.4

Notes
(0002458) rsouissi 11-07-07 09:57	I found out this problem happens because I had this parameter added to my web.xml: <init-param> <param-name>script-encoding</param-name> <param-value>windows-1256</param-value> </init-param> I needed this encoding to support Arabic pages and it used to work in 3.1.2 Non-Pro version.

(0002472) mo 11-09-07 18:27	Hello rsouissi I just tested with phpBB 2.0.22 using the current dev version, the 3.1.3 release and the dev snapshot from 2007/11/06. I was not able to run phpBB with the 3.1.3 release, but it works for me with the current dev version and with the snapshot release. Could you do me a favor and download the snapshot and rerun your test to verify that this bug is fixed? http://caucho.com/download/resin-3_1-snap.zip [^] thanks Mo

(0002475) rsouissi 11-10-07 09:56	Hi, Yes, I tried the latest snapshot (11/06) and the same problem happens. Did you add this to web.xml ? <init-param> <param-name>script-encoding</param-name> <param-value>iso-8859-6</param-value> </init-param> <init-param> <param-name>compile</param-name> <param-value>true</param-value> </init-param> For the encoding, you can try iso-8859-6 and windows-1256, both will fail the same way. This used to work in 3.1.2

(0002477) mo 11-10-07 16:40	Ahh, I am now able to reproduce the problem. Thanks for following up. The minimal test case for this issue is: WEB-INF/resin-web.xml: <web-app xmlns="http://caucho.com/ns/resin"> [^] <servlet servlet-name="resin-php" servlet-class="com.caucho.quercus.servlet.QuercusServlet"> <init> <script-encoding>iso-8859-6</script-encoding> </init> </servlet> <servlet-mapping url-pattern=".php" servlet-name="resin-php"/> </web-app> test/php: <?php // echo OK; ?> This generates: .../script_encoding/test.php:2: '' is an unexpected token, expected an expression. in test.php:1: <?php test.php:2: /**/ test.php:3: echo OK; Added regression test: php\0j19.qa

(0002486) nam 11-13-07 19:07	php/001b

Relationships