0002023: 0 isn't handled as a BooleanValue

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002023

[Quercus]

minor

always

09-24-07 01:00

09-24-07 17:04

Reporter

krogh

View Status

public

Assigned To

nam

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

3.1.3

Product Version

3.1.2

Product Build

Summary

0002023: 0 isn't handled as a BooleanValue

Description

Hello,

trying to install joomla 1.0.13 on glassfish / quercus, I had some problem with xml handling (domit lib used by joomla).

It appears xmlOptionCaseFolding didn't reflect the corresponding option when set using 0 (0 & 1 should be hanlded as boolean depending of the context).

Buggy php code:
xml_parser_set_option($parser, XML_OPTION_CASE_FOLDING, 0);

Working version:
xml_parser_set_option($parser, XML_OPTION_CASE_FOLDING, false);

/quercus/src/com/caucho/quercus/lib/xml/Xml.java
      case XmlModule.XML_OPTION_CASE_FOLDING:
        if (value instanceof BooleanValue) {
          _xmlOptionCaseFolding = value.toBoolean();
          return true;
        } else {
          return false;
        }

I saw similar code many times to handle booleans, mabye it should be replaced by an helper that also check number values (0 => false, any other value => true).

Steps To Reproduce

Additional Information

Attached Files

Relationships

Notes
(0002308) nam 09-24-07 17:04	php/1h0b

Issue History
Date Modified	Username	Field	Change
09-24-07 01:00	krogh	New Issue
09-24-07 01:01	krogh	Issue Monitored: krogh
09-24-07 16:59	nam	Status	new => assigned
09-24-07 16:59	nam	Assigned To	=> nam
09-24-07 17:04	nam	Status	assigned => closed
09-24-07 17:04	nam	Note Added: 0002308
09-24-07 17:04	nam	Resolution	open => fixed
09-24-07 17:04	nam	Fixed in Version	=> 3.1.3

Mantis 1.0.0rc3[^]

30 total queries executed.
26 unique queries executed.