0001991: Cannot run phpBB3RC5

Notes
(0002365) nam 10-18-07 11:42 edited on: 10-18-07 11:54	There is a bug in how Quercus does file locking on Windows. Windows only support mandatory file locking where other applications are prohibited from reading/writing to a locked file. Operating systems with advisory file locking (i.e. Linux) are not affected.

(0002392) mo 10-25-07 15:57	Updated qa test 6000.qa and added 6001.qa and 6002.qa to test read-only and write-only streams.

(0002393) mo 10-25-07 16:09	Attached is one approach to fixing this problem. It involves reworking some pieces in the VFS layer but keeps the changes as small as possible. This patch makes blocking the default for flock, for some reason non-blocking is the default in the current implementation. The patch also makes the FileOutput, FileInput, and FileInputOutput use the actual stream opened by the VFS layer. This avoids the crashing problems under Windows. This patch also returns true when a LOCK_EX is requested for a read-only stream or LOCK_SH is requested for a write-only stream. C PHP seems to allow this for some reason but Java raises a NonReadableChannelException or a NonWritableChannelException exception in these cases. With this patch, 6000.qa, 6001.qa, and 6002.qa all pass. But, it causes regressions in 1646.qa and 164f.qa since they both use the questionable approach of passing LOCK_EX to a read-only stream, or LOCK_SH to a write-only stream.

(0002395) mo 10-26-07 18:14	Added: php/6003.qa php/6004.qa php/6005.qa Updated: php/1646.qa php/164f.qa Made both of the regression tests check a read/write stream so that both LOCK_SH and LOCK_EX could be set on the same stream. The results of these two test cases did not match the native PHP results under Windows. I will also attach an updated patch that takes care of another unhandled problem of releasing the previous lock when setting a new lock.

(0002396) mo 10-26-07 18:21	The new stream_lock2.patch fixes all the current known problems under Windows. It will return false for a flock(LOCK_SH) applied to a write-only stream (php/6003.qa) and for the case where a flock(LOCK_EX) is applied to a read-only stream (php/6004.qa). The code also correctly releases a previously held lock when switching from LOCK_EX to LOCK_SH on a read-write stream (php/6005.qa).

(0002407) mo 10-29-07 14:31	Rechecked the test results under Linux and committed stream_lock3.patch.

Issue History
Date Modified	Username	Field	Change
09-05-07 06:55	rsouissi	New Issue
10-18-07 11:42	nam	Note Added: 0002365
10-18-07 11:54	nam	Note Edited: 0002365
10-25-07 15:53	mo	Status	new => assigned
10-25-07 15:53	mo	Assigned To	=> mo
10-25-07 15:57	mo	Note Added: 0002392
10-25-07 15:58	mo	File Added: stream_lock.patch
10-25-07 16:09	mo	Note Added: 0002393
10-26-07 18:14	mo	Note Added: 0002395
10-26-07 18:15	mo	File Added: 164_flock.patch
10-26-07 18:16	mo	File Added: stream_lock2.patch
10-26-07 18:21	mo	Note Added: 0002396
10-29-07 14:31	mo	Status	assigned => closed
10-29-07 14:31	mo	Note Added: 0002407
10-29-07 14:31	mo	Resolution	open => fixed
10-29-07 14:31	mo	Fixed in Version	=> 3.1.4

Relationships