0001963: return new self(...) fails

(0002227)
rjc
08-23-07 12:26

I temporarily fixed this by changing return new self(...) to return new (__CLASS__)(...) in all classes and subclasses in MediaWiki that used it, but I would appreciate fixing this, because I'd rather not patch the MediaWiki source to work with Quercus.

(0002236)
kim
08-26-07 03:38

Seems to be a parser issue: for 'new self' (no parentheses) it works fine. Changing c.q.p.QuercusParser, lines 3036-3039 (SVN HEAD) to:

        if (!name.equals("self") && token == '(')
          return parseFunction(className, name, isInstantiated);
        else
          return parseConstant(className, name);

works -- however seems more like a quick workaround.

+1 for fixing this as it is indeed a common (and perfectly legal) idiom, used e.g. by the Zend Framework frequently.

(0002257)
nam
09-04-07 11:09

php/093h

Issue History
Date Modified	Username	Field	Change
08-22-07 14:43	rjc	New Issue
08-23-07 12:26	rjc	Note Added: 0002227
08-26-07 03:38	kim	Note Added: 0002236
09-04-07 11:09	nam	Status	new => assigned
09-04-07 11:09	nam	Assigned To	=> nam
09-04-07 11:09	nam	Status	assigned => closed
09-04-07 11:09	nam	Note Added: 0002257
09-04-07 11:09	nam	Resolution	open => fixed
09-04-07 11:09	nam	Fixed in Version	=> 3.1.3

Notes
(0002227) rjc 08-23-07 12:26	I temporarily fixed this by changing return new self(...) to return new (__CLASS__)(...) in all classes and subclasses in MediaWiki that used it, but I would appreciate fixing this, because I'd rather not patch the MediaWiki source to work with Quercus.

(0002236) kim 08-26-07 03:38	Seems to be a parser issue: for 'new self' (no parentheses) it works fine. Changing c.q.p.QuercusParser, lines 3036-3039 (SVN HEAD) to: if (!name.equals("self") && token == '(') return parseFunction(className, name, isInstantiated); else return parseConstant(className, name); works -- however seems more like a quick workaround. +1 for fixing this as it is indeed a common (and perfectly legal) idiom, used e.g. by the Zend Framework frequently.

(0002257) nam 09-04-07 11:09	php/093h

Relationships