0001958: Don't print warnings about unsupported ini values if set to default

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001958

[Quercus]

minor

always

08-21-07 00:49

08-21-07 15:42

Reporter

ntherning

View Status

public

Assigned To

nam

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

3.1.3

Product Version

3.1.2

Product Build

Summary

0001958: Don't print warnings about unsupported ini values if set to default

Description

With drupal 5.2 I see the following warnings on each page:

apache-tomcat-5.5.23/webapps/drupal/dp/sites/default/settings.php:128: Warning: ini value `magic_quotes_runtime' is not supported [ini_set] apache-tomcat-5.5.23/webapps/drupal/dp/sites/default/settings.php:129: Warning: ini value `magic_quotes_sybase' is not supported [ini_set]

Drupal sets these values to 0 (off) which is, IIUC, how Quercus behaves anyway. I.e. setting these values to 0 (off) is actually supported. It's only unsupported to set them to 1 (on), right?

The following patch only prints the warning if you try to set an unsupported ini value to something which is different from the default:

Index: src/com/caucho/quercus/module/IniDefinition.java
===================================================================
--- src/com/caucho/quercus/module/IniDefinition.java (revision 2965)
+++ src/com/caucho/quercus/module/IniDefinition.java (working copy)
@@ -353,6 +353,8 @@
                     int scope,
                     Value value)
     {
+ if (value.eq(super._deflt))
+ return;
       Env.getInstance().warning(L.l("ini value `{0}' is not supported", getName()));
     }
   }

I guess a much better way of doing this would be to introduce a new class, IniDefinition.PartiallySupported, which would only print the warning if an ini value is set to a value which is different from any of the supported values. The above, however, seems to be enough to get drupal 5.2 to work without any patching.

Steps To Reproduce

Additional Information

Attached Files

Relationships

Notes
(0002212) nam 08-21-07 15:42	php/1a0u

Issue History
Date Modified	Username	Field	Change
08-21-07 00:49	ntherning	New Issue
08-21-07 15:42	nam	Status	new => assigned
08-21-07 15:42	nam	Assigned To	=> nam
08-21-07 15:42	nam	Status	assigned => closed
08-21-07 15:42	nam	Note Added: 0002212
08-21-07 15:42	nam	Resolution	open => fixed
08-21-07 15:42	nam	Fixed in Version	=> 3.1.3

Mantis 1.0.0rc3[^]

29 total queries executed.
26 unique queries executed.