0001931: JspExpressionFactoryImpl evaluates the EL string "true" as false.

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001931

[Resin]

major

always

08-06-07 08:26

08-13-07 09:53

Reporter

dheggie

View Status

public

Assigned To

ferg

Priority

normal

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

3.1.3

Product Version

3.1.2

Product Build

Summary

0001931: JspExpressionFactoryImpl evaluates the EL string "true" as false.

Description

I have a JSF page that has many input fields that have the attribute required="true" e.g.
<h:inputText" id="username" value="#{loginAction.username}" required="true">

The string "true" is getting evaluated to the Boolean FALSE before it is set onto the JSF component.

I have tracked down the bug to the coerceToType(Object obj, Class<?> targetType) method in the com.caucho.jsp.el.JspExpressionFactoryImpl class. Line 67 is:

return Expr.toBoolean(obj, null) ? Boolean.FALSE : Boolean.TRUE;

when it should be the opposite e.g.

return Expr.toBoolean(obj, null) ? Boolean.TRUE : Boolean.FALSE;

Steps To Reproduce

Additional Information

I am running Sun's JSF 1.2_04-b16 RI and Jboss Seam 1.2.1 GA.

Attached Files

Relationships

Notes
(0002176) dheggie 08-06-07 08:32	I am also using Facelets 1.1.13

(0002190) ferg 08-13-07 09:53	jsp/32ad

Issue History
Date Modified	Username	Field	Change
08-06-07 08:26	dheggie	New Issue
08-06-07 08:32	dheggie	Note Added: 0002176
08-13-07 09:53	ferg	Note Added: 0002190
08-13-07 09:53	ferg	Assigned To	=> ferg
08-13-07 09:53	ferg	Status	new => closed
08-13-07 09:53	ferg	Resolution	open => fixed
08-13-07 09:53	ferg	Fixed in Version	=> 3.1.3

Mantis 1.0.0rc3[^]

31 total queries executed.
27 unique queries executed.