0001065: JSP precompile and batching

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001065

[Resin]

minor

always

04-20-06 08:18

06-27-06 14:49

Reporter

ferg

View Status

public

Assigned To

ferg

Priority

urgent

Resolution

fixed

Platform

Status

closed

Projection

none

OS Version

ETA

none

Fixed in Version

3.0.20

Product Version

Product Build

Summary

0001065: JSP precompile and batching

Description

(rep by Bill Au)

I had forgotten all about this until I was hit by this problem
again yesterday. It seems to me that adding code to catch
JavaCompileException in the compileBatch() method so that it
will continue onto the next batch would be straight forward.
Can that be added?

With that fix in place. I am still face with the problem that
one bad JSP will cause the while batch (64) of JSPs not to be
precompiled. I guess we will have to live with that since that's
how the Java compiler works.

We have a webapp that contains JSPs whose sole purpose are to
be included into other JSPs. They don't compile on their own.
So they are causing other JSPs being compiled in the same batch
not to be precompiled. I thought a way to get around this would
be to make the JspPrecompileListener look for a <fileset> in
is configuration to specify a set of JSPs for the precompiler listener
to skip. But if the list if large that the overhead of figuring out
which JSPs to skip may be to much. Do you guys
see any good way to get around this?

Steps To Reproduce

Additional Information

Attached Files

Relationships

Notes
(0001326) ferg 06-27-06 14:49	In addition to the exception-catching fix, the batch-max of 64 can be changed in the <java> directive.

Issue History
Date Modified	Username	Field	Change
04-20-06 08:18	ferg	New Issue
06-27-06 14:49	ferg	Note Added: 0001326
06-27-06 14:49	ferg	Assigned To	=> ferg
06-27-06 14:49	ferg	Status	new => resolved
06-27-06 14:49	ferg	Resolution	open => fixed
06-27-06 14:49	ferg	Fixed in Version	=> 3.0.20
06-27-06 14:49	ferg	Status	resolved => closed

Mantis 1.0.0rc3[^]

28 total queries executed.
25 unique queries executed.