0000308: EnvironmentLogger.removeHandle

Mantis - Resin
Viewing Issue Advanced Details

ID:	Category:	Severity:	Reproducibility:	Date Submitted:	Last Update:
308		minor	always	07-12-05 00:00	11-30-05 14:43

Reporter:	ferg	Platform:
Assigned To:		OS:
Priority:	urgent	OS Version:
Status:	closed	Product Version:	3.0.14
Product Build:	3.0.14	Resolution:	fixed
Projection:	none
ETA:	none	Fixed in Version:	3.0.15

Summary:	0000308: EnvironmentLogger.removeHandle
Description:	RSN-351 (rep by Fiaz Hossain) 2. Envoronment Logger should implement removeHandler(). Priority Medium. I had previously sent his to you earlier. The EnvironmentLogger needs to be able to remove a handler cleanly just as it supports addHandler. This is also used by out new Monitoring and Management framework.
Steps To Reproduce:
Additional Information:
Relationships
Attached Files:

Notes

File: com.caucho.log.EnvironmentLogger.java. Needs the following code added to it.
  /**
   * Remove a handler.
   */
  public synchronized void removeHandler(Handler handler)
  {
    ClassLoader loader = Thread.currentThread().getContextClassLoader();

    for (int i = _loaders.size() - 1; i >= 0; i--) {
      SoftReference<ClassLoader> ref = _loaders.get(i);
      ClassLoader refLoader = ref.get();

      if (refLoader == null)
        _loaders.remove(i);

      if (isParentLoader(loader, refLoader))
        removeHandler(handler, refLoader);
    }

    HandlerEntry ownHandlers = _ownHandlers.get();
    if (ownHandlers != null) {
        ownHandlers.removeHandler(handler);
    }
  }

  private void removeHandler(Handler handler, ClassLoader loader)
  {
    ArrayList<Handler> handlers = new ArrayList<Handler>();

    for (ClassLoader ptr = loader; ptr != null; ptr = ptr.getParent()) {
      Handler []localHandlers = _localHandlers.getLevel(ptr);

      if (localHandlers != null) {
        for (int i = 0; i < localHandlers.length; i++) {
          if (!localHandlers[i].equals(handler)) {
                          int p = handlers.indexOf(localHandlers[i]);

                          if (p < 0) {
                            handlers.add(localHandlers[i]);
                          }
                          else {
                            Handler oldHandler = handlers.get(p);

                            if (localHandlers[i].getLevel().intValue()
                                    < oldHandler.getLevel().intValue()) {
                              handlers.set(p, localHandlers[i]);
                            }
                          }
          }
        }
      }
    }

    if (handlers.size() > 0) {
        Handler []newHandlers = new Handler[handlers.size()];
        handlers.toArray(newHandlers);
        _localHandlers.set(newHandlers);
    } else {
            _localHandlers.remove();
    }

    if (handler.getLevel().intValue() <= _level)
      doSetLevel(getLevel());
  }